Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[import] Sort the imports to resolve checkstyle warnings #338

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[import] Sort the imports to resolve checkstyle warnings #338

merged 1 commit into from
Mar 28, 2022

Conversation

hazendaz
Copy link
Collaborator

hang on this until after #327 as it likely might cause merge conflict.

@hazendaz hazendaz requested a review from dbwiddis March 28, 2022 01:45
dbwiddis
dbwiddis approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (waiting on #327).

@mathieucarbou
Copy link
Owner

hang on this until after #327 as it likely might cause merge conflict.

Which is ok, #327 will have to rebase....

@mathieucarbou mathieucarbou merged commit feb0daa into mathieucarbou:master Mar 28, 2022
@mathieucarbou mathieucarbou added is:enhancement Enhancement to an existing feature in:build MLP build system (maven) labels Mar 28, 2022
@mathieucarbou mathieucarbou added this to the 4.2 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieucarbou mathieucarbou mathieucarbou approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

Assignees

@dbwiddis dbwiddis

Labels
in:build MLP build system (maven) is:enhancement Enhancement to an existing feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hazendaz @mathieucarbou @dbwiddis